fix quadratic backtracking in unicode escape normalization#5163
Merged
Conversation
Collaborator
|
Thanks, could you add a changelog entry? Something like "Improve performance on strings containing many consecutive backslashes" |
Contributor
Author
|
Added it under Performance, thanks. |
JelleZijlstra
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
normalize_unicode_escape_sequences runs UNICODE_ESCAPE_RE over every string leaf, and the pattern matched a backslash run with (\+) immediately followed by a required escape body. A long run of backslashes with no trailing u/U/x/N escape makes the engine retry the run from each restart position, so formatting a string of backslashes is quadratic: a 64KB literal already takes minutes, and blackd accepts far larger bodies over the wire. Making the escape body optional lets the whole run be consumed in a single match, which restores linear time and leaves the output identical.