DeprecationWarning in use of msgpack

[jaraco]

Simply running the tests reveals a DeprecationWarning in the use of msgpack.

cachecontrol master $ tox
GLOB sdist-make: /Users/jaraco/code/public/cachecontrol/setup.py
python create: /Users/jaraco/code/public/cachecontrol/.tox/python
python installdeps: pytest, mock, cherrypy, redis, lockfile
python inst: /Users/jaraco/code/public/cachecontrol/.tox/.tmp/package/1/CacheControl-0.12.4.zip
python installed: You are using pip version 10.0.1, however version 18.1 is available.,You should consider upgrading via the 'pip install --upgrade pip' command.,atomicwrites==1.2.1,attrs==18.2.0,backports.functools-lru-cache==1.5,CacheControl==0.12.4,certifi==2018.11.29,chardet==3.0.4,cheroot==6.5.2,CherryPy==18.1.0,idna==2.8,jaraco.functools==1.20,lockfile==0.12.2,mock==2.0.0,more-itertools==4.3.0,msgpack-python==0.5.6,pbr==5.1.1,pluggy==0.8.0,portend==2.3,py==1.7.0,pytest==4.0.1,pytz==2018.7,redis==3.0.1,requests==2.21.0,six==1.12.0,tempora==1.14,urllib3==1.24.1,zc.lockfile==1.4
python run-test-pre: PYTHONHASHSEED='269803362'
python runtests: commands[0] | py.test tests/
================================================================================== test session starts ==================================================================================
platform darwin -- Python 3.7.1, pytest-4.0.1, py-1.7.0, pluggy-0.8.0
cachedir: .tox/python/.pytest_cache
rootdir: /Users/jaraco/code/public/cachecontrol, inifile: setup.cfg
collected 83 items

tests/test_adapter.py .........                                                                                                                                                   [ 10%]
tests/test_cache_control.py ...................                                                                                                                                   [ 33%]
tests/test_chunked_response.py ...                                                                                                                                                [ 37%]
tests/test_etag.py ...                                                                                                                                                            [ 40%]
tests/test_expires_heuristics.py ................                                                                                                                                 [ 60%]
tests/test_max_age.py ..                                                                                                                                                          [ 62%]
tests/test_redirects.py ....                                                                                                                                                      [ 67%]
tests/test_regressions.py ..                                                                                                                                                      [ 69%]
tests/test_serialization.py ..........                                                                                                                                            [ 81%]
tests/test_server_http_version.py .                                                                                                                                               [ 83%]
tests/test_storage_filecache.py ...........                                                                                                                                       [ 96%]
tests/test_storage_redis.py .                                                                                                                                                     [ 97%]
tests/test_stream.py .                                                                                                                                                            [ 98%]
tests/test_vary.py .                                                                                                                                                              [100%]

=================================================================================== warnings summary ====================================================================================
tests/test_adapter.py::TestSessionActions::test_get_caches[use_adapter]
  /Users/jaraco/code/public/cachecontrol/.tox/python/lib/python3.7/site-packages/cachecontrol/serialize.py:190: PendingDeprecationWarning: encoding is deprecated, Use raw=False instead.
    cached = msgpack.loads(data, encoding='utf-8')

tests/test_adapter.py::TestSessionActions::test_get_caches[use_wrapper]
  /Users/jaraco/code/public/cachecontrol/.tox/python/lib/python3.7/site-packages/cachecontrol/serialize.py:190: PendingDeprecationWarning: encoding is deprecated, Use raw=False instead.
    cached = msgpack.loads(data, encoding='utf-8')

tests/test_adapter.py::TestSessionActions::test_get_with_no_cache_does_not_cache[use_adapter]
  /Users/jaraco/code/public/cachecontrol/.tox/python/lib/python3.7/site-packages/cachecontrol/serialize.py:190: PendingDeprecationWarning: encoding is deprecated, Use raw=False instead.
    cached = msgpack.loads(data, encoding='utf-8')

tests/test_adapter.py::TestSessionActions::test_get_with_no_cache_does_not_cache[use_wrapper]
  /Users/jaraco/code/public/cachecontrol/.tox/python/lib/python3.7/site-packages/cachecontrol/serialize.py:190: PendingDeprecationWarning: encoding is deprecated, Use raw=False instead.
    cached = msgpack.loads(data, encoding='utf-8')

tests/test_chunked_response.py::TestChunkedResponses::test_cache_chunked_response
  /Users/jaraco/code/public/cachecontrol/.tox/python/lib/python3.7/site-packages/cachecontrol/serialize.py:190: PendingDeprecationWarning: encoding is deprecated, Use raw=False instead.
    cached = msgpack.loads(data, encoding='utf-8')

tests/test_chunked_response.py::TestChunkedResponses::test_stream_is_cached
  /Users/jaraco/code/public/cachecontrol/.tox/python/lib/python3.7/site-packages/cachecontrol/serialize.py:190: PendingDeprecationWarning: encoding is deprecated, Use raw=False instead.
    cached = msgpack.loads(data, encoding='utf-8')

tests/test_etag.py::TestReleaseConnection::test_not_modified_releases_connection
  /Users/jaraco/code/public/cachecontrol/.tox/python/lib/python3.7/site-packages/cachecontrol/serialize.py:190: PendingDeprecationWarning: encoding is deprecated, Use raw=False instead.
    cached = msgpack.loads(data, encoding='utf-8')
  /Users/jaraco/code/public/cachecontrol/.tox/python/lib/python3.7/site-packages/cachecontrol/serialize.py:190: PendingDeprecationWarning: encoding is deprecated, Use raw=False instead.
    cached = msgpack.loads(data, encoding='utf-8')
  /Users/jaraco/code/public/cachecontrol/.tox/python/lib/python3.7/site-packages/cachecontrol/serialize.py:190: PendingDeprecationWarning: encoding is deprecated, Use raw=False instead.
    cached = msgpack.loads(data, encoding='utf-8')

tests/test_expires_heuristics.py::TestOneDayCache::test_cache_for_one_day
  /Users/jaraco/code/public/cachecontrol/.tox/python/lib/python3.7/site-packages/cachecontrol/serialize.py:190: PendingDeprecationWarning: encoding is deprecated, Use raw=False instead.
    cached = msgpack.loads(data, encoding='utf-8')

tests/test_expires_heuristics.py::TestExpiresAfter::test_expires_after_one_day
  /Users/jaraco/code/public/cachecontrol/.tox/python/lib/python3.7/site-packages/cachecontrol/serialize.py:190: PendingDeprecationWarning: encoding is deprecated, Use raw=False instead.
    cached = msgpack.loads(data, encoding='utf-8')

tests/test_expires_heuristics.py::TestLastModified::test_last_modified
  /Users/jaraco/code/public/cachecontrol/.tox/python/lib/python3.7/site-packages/cachecontrol/serialize.py:190: PendingDeprecationWarning: encoding is deprecated, Use raw=False instead.
    cached = msgpack.loads(data, encoding='utf-8')

tests/test_redirects.py::TestPermanentRedirects::test_redirect_response_is_cached
  /Users/jaraco/code/public/cachecontrol/.tox/python/lib/python3.7/site-packages/cachecontrol/serialize.py:190: PendingDeprecationWarning: encoding is deprecated, Use raw=False instead.
    cached = msgpack.loads(data, encoding='utf-8')

tests/test_redirects.py::TestPermanentRedirects::test_bust_cache_on_redirect
  /Users/jaraco/code/public/cachecontrol/.tox/python/lib/python3.7/site-packages/cachecontrol/serialize.py:190: PendingDeprecationWarning: encoding is deprecated, Use raw=False instead.
    cached = msgpack.loads(data, encoding='utf-8')

tests/test_redirects.py::TestMultipleChoicesRedirects::test_multiple_choices_is_cacheable
  /Users/jaraco/code/public/cachecontrol/.tox/python/lib/python3.7/site-packages/cachecontrol/serialize.py:190: PendingDeprecationWarning: encoding is deprecated, Use raw=False instead.
    cached = msgpack.loads(data, encoding='utf-8')

tests/test_redirects.py::TestMultipleChoicesRedirects::test_bust_cache_on_redirect
  /Users/jaraco/code/public/cachecontrol/.tox/python/lib/python3.7/site-packages/cachecontrol/serialize.py:190: PendingDeprecationWarning: encoding is deprecated, Use raw=False instead.
    cached = msgpack.loads(data, encoding='utf-8')

tests/test_regressions.py::Test39::test_file_cache_recognizes_consumed_file_handle
  /Users/jaraco/code/public/cachecontrol/.tox/python/lib/python3.7/site-packages/cachecontrol/serialize.py:190: PendingDeprecationWarning: encoding is deprecated, Use raw=False instead.
    cached = msgpack.loads(data, encoding='utf-8')

tests/test_serialization.py::TestSerializer::test_read_version_v4
  /Users/jaraco/code/public/cachecontrol/.tox/python/lib/python3.7/site-packages/cachecontrol/serialize.py:190: PendingDeprecationWarning: encoding is deprecated, Use raw=False instead.
    cached = msgpack.loads(data, encoding='utf-8')

tests/test_serialization.py::TestSerializer::test_read_latest_version_streamable
  /Users/jaraco/code/public/cachecontrol/.tox/python/lib/python3.7/site-packages/cachecontrol/serialize.py:190: PendingDeprecationWarning: encoding is deprecated, Use raw=False instead.
    cached = msgpack.loads(data, encoding='utf-8')

tests/test_serialization.py::TestSerializer::test_read_latest_version
  /Users/jaraco/code/public/cachecontrol/.tox/python/lib/python3.7/site-packages/cachecontrol/serialize.py:190: PendingDeprecationWarning: encoding is deprecated, Use raw=False instead.
    cached = msgpack.loads(data, encoding='utf-8')

tests/test_serialization.py::TestSerializer::test_no_vary_header
  /Users/jaraco/code/public/cachecontrol/.tox/python/lib/python3.7/site-packages/cachecontrol/serialize.py:190: PendingDeprecationWarning: encoding is deprecated, Use raw=False instead.
    cached = msgpack.loads(data, encoding='utf-8')

tests/test_storage_filecache.py::TestStorageFileCache::test_filecache_from_cache
  /Users/jaraco/code/public/cachecontrol/.tox/python/lib/python3.7/site-packages/cachecontrol/serialize.py:190: PendingDeprecationWarning: encoding is deprecated, Use raw=False instead.
    cached = msgpack.loads(data, encoding='utf-8')

tests/test_stream.py::TestStream::test_stream_is_cached
  /Users/jaraco/code/public/cachecontrol/.tox/python/lib/python3.7/site-packages/cachecontrol/serialize.py:190: PendingDeprecationWarning: encoding is deprecated, Use raw=False instead.
    cached = msgpack.loads(data, encoding='utf-8')

tests/test_vary.py::TestVary::test_vary_example
  /Users/jaraco/code/public/cachecontrol/.tox/python/lib/python3.7/site-packages/cachecontrol/serialize.py:190: PendingDeprecationWarning: encoding is deprecated, Use raw=False instead.
    cached = msgpack.loads(data, encoding='utf-8')
  /Users/jaraco/code/public/cachecontrol/.tox/python/lib/python3.7/site-packages/cachecontrol/serialize.py:190: PendingDeprecationWarning: encoding is deprecated, Use raw=False instead.
    cached = msgpack.loads(data, encoding='utf-8')
  /Users/jaraco/code/public/cachecontrol/.tox/python/lib/python3.7/site-packages/cachecontrol/serialize.py:190: PendingDeprecationWarning: encoding is deprecated, Use raw=False instead.
    cached = msgpack.loads(data, encoding='utf-8')
  /Users/jaraco/code/public/cachecontrol/.tox/python/lib/python3.7/site-packages/cachecontrol/serialize.py:190: PendingDeprecationWarning: encoding is deprecated, Use raw=False instead.
    cached = msgpack.loads(data, encoding='utf-8')

-- Docs: https://docs.pytest.org/en/latest/warnings.html
======================================================================== 83 passed, 27 warnings in 12.66 seconds ========================================================================
[11/Dec/2018:01:38:34] ENGINE HTTP Server cherrypy._cpwsgi_server.CPWSGIServer(('127.0.0.1', 62604)) shut down
________________________________________________________________________________________ summary ________________________________________________________________________________________
  python: commands succeeded
  congratulations :)

[yan12125]

My pull request #197 fixes the issue, but the py34 test on Travis fails for some unknown reasons.

UPDATE: TheJokr found the reason for failing tests, and #197 is now merged.

[hiranya911]

Any plans to release this fix soon?

[rollue]

@ionrock If seems msgpack-python new release(v1.0.0rc1) has actually deprecated this line of code and so it is now causing errors in production. New release needed as it seems fix has been merged into master branch.

[ionrock]

Done! https://pypi.org/project/CacheControl/0.12.6

[rollue]

@ionrock Couldn't expect a faster response. Thanks!

[hexagonrecursion]

Done! https://pypi.org/project/CacheControl/0.12.6

Did you forget to close this issue?