urllib3 has been updated to new version 1.8.1, "source_address" is supported. May the requests lib support it?

[bofortitude]

New version urllib3 has been updated to 1.8.1 which support the "source_address"(in Python v2.7). Could you do something change to support it. It's really useful and needed. I will appreciate it very much.

[Lukasa]

Thanks for raising this issue!

Requests doesn't plan to add this to the main API, it's simply not commonly used enough to justify the increased complexity. My recommendation is that you use our Transport Adapter abstraction to provide the value. The example adapter that I linked to should provide enough of an example to demonstrate how this would work, but let me know if it didn't and I'll demonstrate.

[bofortitude]

@Lukasa Thanks for your reply. But, what I want is to send http requests with specifying source address. I've no idea how to use the Transport Adapter abstraction to finish this. Maybe you can give an example how it does.

[Lukasa]

Doing it at the per-request level is very difficult, but you can do it at either a global level or a per-host level.

For example:

import requests
from requests.adapters import HTTPAdapter
from requests.packages.urllib3.poolmanager import PoolManager


class SourceAddressAdapter(HTTPAdapter):
    def __init__(self, source_address, **kwargs):
        self.source_address = source_address

        super(SourceAddressAdapter, self).__init__(**kwargs)

    def init_poolmanager(self, connections, maxsize, block=False):
        self.poolmanager = PoolManager(num_pools=connections,
                                       maxsize=maxsize,
                                       block=block,
                                       source_address=self.source_address)

s = requests.Session()
s.mount('http://', SourceAddressAdapter('10.10.10.10'))
s.mount('https://', SourceAddressAdapter('12.12.12.12'))
s.mount('http://github.com/', SourceAddressAdapter('120.120.120.120'))

This code will set the source address to 10.10.10.10 for all HTTP traffic, and 12.12.12.12 for all HTTPS traffic except when sending to GitHub, when it'll use 120.120.120.120. Is this suitably useful?

[bofortitude]

@Lukasa Great! That's what I want. After replacing with the new version urllib3, I did it! I hope there will be new version requests which embedded with new urllib3 as soon as possible.
It's so kind of you to show me this! Thanks you again.

[Lukasa]

No problem, I'll make sure we update urllib3 before our next release. =)

[sigmavirus24]

Should we move the SourceAddressAdapter into the toolbelt?

[Lukasa]

Let's do it. =)

[sigmavirus24]

PRs welcome. :)

Thinking we should have an adapters submodule for it. ;)

[gosom]

@Lukasa

thanks for the above dode
your code above have a small issue.

SourceAddressAdapter('10.10.10.10'))

the source_address should be a pair (host, port).

You pass a string and this will cause an exception when the sock.bind method is called.

The correct way is to pass a tuple like:

SourceAddressAdapter( ('10.10.10.10', 0) )

cheers

[Lukasa]

@gosom You're quite right: the version of the code in requests-toolbelt does not have this problem.

[gosom]

@Lukasa
I think the version of the code should not work with the current requrests version.

check here:https://github.com/kennethreitz/requests/blob/master/requests/packages/urllib3/util/connection.py#L77

The socket.bind method it is called and you get an exception if you pass a string.

Ok, this is not a bug but would be nice to be documented that source_address
should be a (host, post) tuple.
cheers