Fix test_conflicting_post_params to work on pytest 5#5305
Merged
nateprewitt merged 3 commits intopsf:masterfrom May 9, 2020
Merged
Fix test_conflicting_post_params to work on pytest 5#5305nateprewitt merged 3 commits intopsf:masterfrom
nateprewitt merged 3 commits intopsf:masterfrom
Conversation
The non-contextmanager form of pytest.raises was removed in pytest 5. http://doc.pytest.org/en/latest/deprecations.html#raises-warns-with-a-string-as-the-second-argument It was used here to support Python < 2.7, but that is no longer needed. psf#1503 (comment) Fixes psf#5304
Contributor
Author
|
What can I do to help getting this merged? I consider the change fairly trivial, self contained and easy to grasp. But the more this remains open, the chances of diverging are getting higher. If there is anything else required from my side, please do let me know. |
Member
|
Thanks @hroncok! |
nateprewitt
approved these changes
May 9, 2020
Contributor
Author
|
Thanks for merging @nateprewitt. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The non-contextmanager form of pytest.raises was removed in pytest 5.
http://doc.pytest.org/en/latest/deprecations.html#raises-warns-with-a-string-as-the-second-argument
It was used here to support Python < 2.7, but that is no longer needed.
#1503 (comment)
Fixes #5304