Update publish workflow#7206
Merged
nateprewitt merged 2 commits intomainfrom Feb 13, 2026
Merged
Conversation
sigmavirus24
approved these changes
Feb 13, 2026
Member
Author
|
For auditing purposes, it looks like things are working: Workflow Job: https://github.com/psf/requests/actions/runs/22001688121/job/63575693896 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should fix the issues with trusted publishing from the 2.32.5 release and modernizes a few things. We get rid of our inline SLSA generation in favor of the workflow built into
gh-action-pypi-publish. I've specifically setattestation: truedespite that being the default to be clear about intent.We can now trigger a manual workflow from GH to test PyPI to verify things are working. Ideally, we would move our versioning to something like setuptools_scm to let us do auto versioning. That would let us mimic urllib3's workflow that autopublishes every push to main. I've saved that until after we gauge impact of moving to PEP 517.
The underlying issue for our failure in #7013 appears to be related to the environment name in the file not matching what was configured in PyPI. That should be fixed now.