Fix: Handle both uppercase and lowercase Content-Type header keys#7241
Closed
Fix: Handle both uppercase and lowercase Content-Type header keys#7241
Conversation
The get_encoding_from_headers function was only checking for lowercase 'content-type' key, but HTTP headers are often passed with uppercase 'Content-Type'. This caused the function to return None when headers had uppercase keys, even when a valid charset was present. Fixes: psf#7234
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix for issue #7234: Quoted charset values are not detected by
get_encoding_from_headersProblem
The
get_encoding_from_headersfunction was only checking for lowercasecontent-typekey, but HTTP headers are often passed with uppercaseContent-Type. This caused the function to returnNonewhen headers had uppercase keys, even when a valid charset was present.Solution
Check for both
content-type(lowercase) andContent-Type(uppercase) header keys.Test
Fixes
#7234