Fix HTTPDigestAuth uri field truncated by semicolons in URL path#7413
Open
zons-zhaozhy wants to merge 1 commit intopsf:mainfrom
Open
Fix HTTPDigestAuth uri field truncated by semicolons in URL path#7413zons-zhaozhy wants to merge 1 commit intopsf:mainfrom
zons-zhaozhy wants to merge 1 commit intopsf:mainfrom
Conversation
urllib.parse.urlparse splits path parameters (delimited by semicolons) into the .params attribute. The build_digest_header method was only using .path and .query, causing the uri field in the Authorization header to be truncated for URLs with matrix-style parameters. Fixes psf#6990
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a URL contains path parameters delimited by semicolons (e.g.
https://musicbrainz.org/ws/2/artist;name=Nirvana),urllib.parse.urlparsesplits the path into.pathand.paramsattributes.HTTPDigestAuth.build_digest_header()was only using.pathand.query, so theurifield in theAuthorizationheader was truncated, causing authentication to fail on servers that validate the full request URI.This was reported in #6990 with a concrete MusicBrainz API example.
Fix: include
p_parsed.paramswhen reconstructing the path inbuild_digest_header().Added a unit test that verifies the
urifield includes semicolon-delimited path parameters.