Constrain Response.reason to str#7437
Merged
Merged
Conversation
sigmavirus24
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to how we moved
status_codetointto avoid needing to doNonechecks before doingstatus_code<400comparisons, we'll do the same ignore forreason.While
reasonis explicitly optional, in practice, urllib3 will always supply an empty str ('') when it's not present in the status line. This is an ergonomics change where the types may not represent all possible values, but a Response initialized by Requests will always populate the field. Anyone instantiating Responses manually will need to take considerations for their construction.