Fix JsonType to accept Mapping[str, Any] instead of recursive Mapping[str, "JsonType"]#7449
Open
driphtyio wants to merge 1 commit into
Open
Fix JsonType to accept Mapping[str, Any] instead of recursive Mapping[str, "JsonType"]#7449driphtyio wants to merge 1 commit into
driphtyio wants to merge 1 commit into
Conversation
The recursive JsonType definition used Mapping[str, "JsonType"], which caused mypy to reject valid dict subtypes like dict[str, object] or dict[str, Collection[str]] due to mypy's invariance handling of recursive Mapping types. The fix replaces the recursive Mapping value type with Any, matching how Python's json.dumps actually accepts any serializable value. Fixes psf#7443
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7443
Problem
The recursive
JsonTypedefinition usedMapping[str, "JsonType"], which causes mypy to reject valid dict subtypes likedict[str, object]ordict[str, Collection[str]]due to mypy's invariance handling of recursive Mapping types.Reproduction
Fix
Replaced the recursive
Mapping[str, "JsonType"]withMapping[str, Any]. This matches how Python'sjson.dumpsactually accepts any serializable value.Anyis the standard pattern used by CPython'sjsonmodule stubs for the same purpose.Testing
pyrightandtycontinue to work correctly