fix: verify=False precedence over REQUESTS_CA_BUNDLE env var (#3829)#7495
Closed
daviediao-code wants to merge 2 commits into
Closed
fix: verify=False precedence over REQUESTS_CA_BUNDLE env var (#3829)#7495daviediao-code wants to merge 2 commits into
daviediao-code wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3829 —
verify=Falseis ignored whenREQUESTS_CA_BUNDLEorCURL_CA_BUNDLEenv var is set.Root Cause
In
merge_environment_settings, the conditionif verify is True or verify is None:means the env var check runs whenverifyis eitherTrue(default) orNone(unset). Whenverify=Falseis explicitly set, the env var check is skipped — but whensession.verify=Falseis set and no param is passed (verify=None), the env var overrides the session's explicitFalse.Fix
Changed
if verify is True or verify is None:→if verify is True:This ensures env vars only apply when the user has not explicitly set
verifyat all (i.e., when it defaults toTrue).requests.get(url, verify=False)session.verify=False; session.get(url)requests.get(url)+ CA_BUNDLETest
Added
test_verify_false_precedence_over_env_certsto verify the fix.