Fixes bug in initialisation of ADC guess vectors #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
dgasmith
approved these changes
Mar 5, 2022
| de = np.linalg.norm(theta[:k] - theta_old) | ||
| if de < tol: | ||
| conv = True | ||
| b = np.dot(b, alpha) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When initialising the guess vectors for ADC, an identity matrix in the full space was briefly initialised, which is O(N^6) and O(N^8) in memory for IP/EA- and EE-ADC(2), respectively (!). This oversight is fine for these small examples but is very bad if people wanted to use the code as a reference for larger systems!
What are your new additions? Please provide a brief list.
Status