Add type annotations on base.py#423
Merged
Merged
Conversation
- Add type annotations to function signatures, variables and constants in `did/base.py` - Add runtime checks for Config.parser initialization with proper error handling - Convert mutable default arguments from lists to tuples in `items.py`, matching types in `base.py` - Add return type annotations to all test functions - Fix test assertions to use correct module references (did.utils vs did.base) - Update test data structures from strings to lists for better type consistency - Split and reorganize test functions for better maintainability - Import Iterator type for proper context manager typing Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
did/base.pyConfig.parserinitialization with proper error handlingitems.py, matching types inbase.pydid.utilsvsdid.base)Iteratortype for proper context manager typing