fix: improve failover resilience and observability#49
Merged
Conversation
Port incident fixes from getmateo fork: gracefully handle sink errors during failover replay, skip unnecessary table sync copies, and upgrade failure-path logging from info to warn with structured fields. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
psteinroe
added a commit
that referenced
this pull request
Apr 5, 2026
- Reverts the error-swallowing behavior introduced in #49 for sink failures during failover replay - Returning `Ok(())` on sink error would let the stream complete recovery and mark itself `Healthy`, even though not all events were replayed — causing data loss with flaky destinations - Propagating the error with `?` lets the destination's retry logic handle transient failures Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TableSyncCopyConfigtoSkipAllTablessincewrite_table_rowsis a no-op — avoids unnecessary work during initial syncinfo→warnwith structured fields (checkpoint_event_id,error) for all failover/failure paths, and added startup warning when stream begins in failover mode