feat: ical token hash param#86
Merged
Merged
Conversation
|
🚀 Deployed on https://deploy-preview-86--psumaps-miniapp.netlify.app |
esperor
requested changes
Nov 2, 2024
Collaborator
esperor
left a comment
esperor
left a comment
There was a problem hiding this comment.
Считаю, что нужно разделить функцию на более маленькие части и покрыть тестами, где наиболее сложнаял логика. В текущем исполнении функция почти нечитаема.
Переход на if вместо switch так же решение сомнительное с точки зрения читабельности, стоит подумать над чем-то другим.
Ну и по классике хорошо бы адресовать warning'и линтера
ijo42
force-pushed
the
feat-ical-param
branch
from
e33042c to
469ff0d
Compare
esperor
approved these changes
Jan 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
добавлена обработка парама 'ical=\w+' для открытия карты одновременно с авторизацией