Use simple query protocol to execute BEGIN/COMMIT out of pipeline mode#820
Merged
Use simple query protocol to execute BEGIN/COMMIT out of pipeline mode#820
Conversation
dvarrazzo
force-pushed
the
commit-simple-protocol
branch
from
ba2f26e to
a25378a
Compare
This was referenced May 14, 2024
dlax
approved these changes
May 14, 2024
…eline We started using the extended protocol in e507918 to fix #350, but, probably to keep symmetry, we also changed the behaviour out of the pipeline. This turns out to be a problem for people connecting to the PgBouncer admin console. They can use the `ClientCursor`, which tries to use the simple protocol as much as it can, but they currently have to use autocommit. With this changeset autocommit shouldn't be needed anymore. See #808.
dvarrazzo
force-pushed
the
commit-simple-protocol
branch
from
a25378a to
7479bae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We started using the extended protocol in e507918 to fix #350, but, probably to keep symmetry, we also changed the behaviour out of the pipeline.
This turns out to be a problem for people connecting to the PgBouncer admin console. They can use the
ClientCursor, which tries to use the simple protocol as much as it can, but they currently have to use autocommit. With this changeset autocommit shouldn't be needed anymore. See #808.