Skip to content

refactor: Unnecessary confirm dialog #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2025
Merged

refactor: Unnecessary confirm dialog #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
264 changes: 0 additions & 264 deletions p3/app/confirm_helper.py
View file
Open in desktop

This file was deleted.

3 changes: 3 additions & 0 deletions p3/app/term_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,9 @@ def _run_next_script(self):
self.vbox_main._update_header_labels(current_script)

script_path = current_script.get('path', 'true')
if current_script.get('reboot') == "yes":
self.parent.reboot_required = True

script_dir = str(os.path.join(os.path.dirname(os.path.dirname(__file__))))

shell_exec = ["/bin/bash", f"{script_path}"]
Expand Down
16 changes: 3 additions & 13 deletions p3/app/window.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
from . import parser
from . import header
from . import footer
from . import confirm_helper
from . import compat
from . import head_menu
from . import reboot_helper
Expand Down Expand Up @@ -572,10 +571,6 @@ def on_category_clicked(self, widget, event):

# If this is a root script (shown as a category), execute it directly
if info.get('is_script'):
# Show confirmation dialog before executing root script
if not confirm_helper.show_single_script_confirmation(info, self, self.translations):
return # User cancelled

# Use VTE-based term_view for execution
self.open_term_view([info])
else:
Expand Down Expand Up @@ -721,10 +716,7 @@ def on_language_changed(self, new_language_code):

# Load new translations
self.translations = lang_utils.load_translations(new_language_code)

# Update the script runner's translations
self.script_runner.translations = self.translations


# Update search engine translations
self.search_engine.update_translations(self.translations)

Expand Down Expand Up @@ -1456,10 +1448,8 @@ def _activate_search_result(self, search_result):
self._show_reboot_warning_dialog()
return

# Show confirmation dialog before executing script
if confirm_helper.show_single_script_confirmation(item_info, self, self.translations):
# Use VTE-based term_view for execution
self.open_term_view([item_info])
# Use VTE-based term_view for execution
self.open_term_view([item_info])

def _clear_search_results(self):
"""Clear search results and return to previous view."""
Expand Down