Skip to content

Conversation

@Boy132
Copy link
Contributor

@Boy132 Boy132 commented Jul 1, 2022

A backport of v2's file upload status. (c6dccc5)
I only changed two things:

  1. Changed the timeout before a completed upload is removed from 5 to 2 seconds. (UploadButton.tsx#L111)
  2. Added the total and loaded bytes next to the name. (FileManagerStatus.tsx#L61)

file_upload

@KaspianDev
Copy link

After applying this patch drag & drop no longer works.

@Boy132
Copy link
Contributor Author

Boy132 commented Jul 3, 2022

After applying this patch drag & drop no longer works.

I can't reproduce that with the given information. ("no longer works" isn't very descriptive)
You maybe got some conflicting third party mod or forget some changes when applying?

@KaspianDev
Copy link

KaspianDev commented Jul 3, 2022

After applying this patch drag & drop no longer works.

I can't reproduce that. You maybe got some conflicting third party mod or forget some changes when applying?

I run ptero panel from latest commit (as of this message), no mods

Edit: Tried again on 1.9.2, same result

@notAreYouScared notAreYouScared mentioned this pull request Jul 5, 2022
1 task
@camwhi-te
Copy link
Contributor

I'm running into the same issue with this (although my instance is modified).

@Boy132
Copy link
Contributor Author

Boy132 commented Jul 6, 2022

What browser are you using? What files are you using? (amount of files, size of files, file types etc.)
Also, can you try on an unmodified panel? Just to be sure.

@KaspianDev
Copy link

What browser are you using? What files are you using? (amount of files, size of files, file types etc.) Also, can you try on an unmodified panel? Just to be sure.

Firefox, one 10KB yml file

Works fine on unmodified panel

@Jelcoo
Copy link
Contributor

Jelcoo commented Jul 6, 2022

This seems to be a problem on the Firefox browser.
The first browser is Firefox, the second one is Microsoft Edge.
https://user-images.githubusercontent.com/53396500/177564610-b9d6fe76-294f-4b9c-af3f-b8cd5431d34a.mp4

@Boy132
Copy link
Contributor Author

Boy132 commented Jul 6, 2022

Turns out Firefox also adds a application/x-moz-file file to the drag event that caused these issues.

@KaspianDev
Copy link

KaspianDev commented Jul 24, 2022

I updated the patch, nothing changed.

Firefox 103.0b9 (64-bit)

Edit: uploading files from file manager is fine, but from the "downloads" popup in firefox no, (but that one still works in original pterodactyl, without patch). Maybe there's something else we forgot about?

Edit 2: This might be the fix, https://stackoverflow.com/a/10703964/13768631

@DaneEveritt DaneEveritt merged commit 1224284 into pterodactyl:develop Jul 24, 2022
@KaspianDev
Copy link

KaspianDev commented Jul 24, 2022

@DaneEveritt compat issues with that one still aren't fixed.

#4279

@Boy132 Boy132 deleted the backport/file-upload-status branch July 25, 2022 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants