Merged
Conversation
Increment atfork_sz after registering an entry in my___register_atfork and my32___register_atfork, matching the working pattern in wrappedlibpthread.c. Without the increment, each registration overwrites slot 0 and all prior handlers are lost. Fixed parent/child atfork loops from --i to ++i in x64emu_fork(). Starting at i=0 with --i causes an infinite loop with out-of-bounds access when atfork_sz > 0. Changed to ++i to iterate forward, matching the POSIX requirement that parent and child handlers execute in registration order (FIFO), consistent with the existing prepare loop which correctly iterates in reverse (LIFO). Fixes ptitSeb#3455
Owner
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increment atfork_sz after registering an entry in my___register_atfork and my32___register_atfork, matching the working pattern in wrappedlibpthread.c. Without the increment, each registration overwrites slot 0 and all prior handlers are lost.
The two bugs mask each other. Since atfork_sz is never incremented by __register_atfork, it stays 0, so the broken loops are never reached with a nonzero count. Programs that register atfork handlers via pthread_atfork (which calls wrappedlibpthread.c and does increment correctly) would hit Bug 2 though — their parent/child handlers silently never run.
Fixes #3455