[LA64_DYNAREC] Close the fastnan path for MINSS/MAXSS/VMINSS/VMAXSS to correct NaN semantics.#3486
Merged
ptitSeb merged 1 commit intoptitSeb:mainfrom Feb 10, 2026
Merged
Conversation
…o correct NaN semantics. Signed-off-by: Zewei Yang <yangzewei@loongson.cn>
Owner
|
This is in par with ARM64 backend |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
LoongArch's
FMIN_S/FMAX_Srules for determining NaN are inconsistent with x86'sMINSS/MAXSS.This causes NaN handling errors when
dynarec_fastnan=1(error scenario observed:numpy max/argmaxreturns 1.0 instead ofnan).Test Code:
If we need to check whether d0/d1 is NaN in order to preserve fastnan(FMAX_S), it might actually be slower.