[PPC64LE_DYNAREC] Add CMP, TEST, ADC and SBB opcodes#3684
Merged
ptitSeb merged 1 commit intoptitSeb:mainfrom Mar 23, 2026
Merged
[PPC64LE_DYNAREC] Add CMP, TEST, ADC and SBB opcodes#3684ptitSeb merged 1 commit intoptitSeb:mainfrom
ptitSeb merged 1 commit intoptitSeb:mainfrom
Conversation
ptitSeb
reviewed
Mar 19, 2026
ptitSeb
reviewed
Mar 19, 2026
ptitSeb
reviewed
Mar 19, 2026
ptitSeb
approved these changes
Mar 19, 2026
ptitSeb
reviewed
Mar 19, 2026
ptitSeb
reviewed
Mar 19, 2026
ptitSeb
requested changes
Mar 19, 2026
Owner
ptitSeb
left a comment
ptitSeb
left a comment
There was a problem hiding this comment.
emit_sbb8 && emit_sbb16 pending result to fix
- CMP: 0x38 (Eb,Gb), 0x39 (Ed,Gd), 0x3A (Gb,Eb), 0x3B (Gd,Ed),
0x3C (AL,Ib), 0x3D (EAX,Id)
- TEST: 0x84 (Eb,Gb), 0x85 (Ed,Gd), 0xA8 (AL,Ib), 0xA9 (EAX,Id)
- ADC: (0x10-0x15)
- SBB (0x18-0x1D)
ptitSeb
approved these changes
Mar 19, 2026
ksco
approved these changes
Mar 23, 2026
Collaborator
ksco
left a comment
ksco
left a comment
There was a problem hiding this comment.
Sorry, please remind me if I haven't reviewed your PR within 24 hours.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #242