Remove PR filter from release action #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the pull-request guard from the release workflow and applies minor naming tweaks across workflows.
- Remove
if: github.event_name != 'pull_request'from thepublish-releasejob and its steps - Rename the code style check step for consistent naming in the test workflow
- Fix apostrophe usage in job/step names in the merge-bot PR workflow
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/test.yml | Renamed step from “Checks code style” to “Check code style” |
| .github/workflows/publish-release.yml | Removed PR filter conditions so release steps now run on PRs |
| .github/workflows/merge-bot-pr.yml | Updated “PR’s” to “PRs” in job and step names |
Comments suppressed due to low confidence (1)
.github/workflows/publish-release.yml:21
- Removing the PR filter allows publishing steps (NuGet push, release creation) to run on pull_request events, exposing secrets and causing unintended releases. Consider restoring a condition that restricts this job to push or tag events only.
needs: test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.