Record develop-staleness and issue-closing learnings in AGENTS.md#233
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates contributor/agent guidance in AGENTS.md to capture two process learnings from recent CI/CD work - keeping develop aligned when fixes land directly on main, and ensuring issue auto-close keywords are applied where GitHub will actually act on them.
Changes:
- Add guidance to mirror
main-only fixes back todevelopand to checkgit diff origin/develop origin/mainbefore relying ondevelop. - Add guidance about placing
Closes #Non thedevelop -> mainpromotion PR to ensure GitHub closes the issue on merge to the default branch.
ptr727
force-pushed
the
docs/agents-learnings
branch
from
608dc40 to
7649f1a
Compare
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ptr727
force-pushed
the
docs/agents-learnings
branch
from
7649f1a to
d47d5bf
Compare
This was referenced Jul 3, 2026
ptr727
added a commit
that referenced
this pull request
Jul 3, 2026
…#236) Refines the develop-staleness guidance added in #233. Driving that promotion (#235) exposed that the `git log origin/develop..origin/main` form is noisy in this repo's bots-target-both model. ## Why Running `git log origin/develop..origin/main` on a clean, current `develop` returned ~50 commits - all routine promotion merges and `main`-direct dependabot/codegen commits whose content `develop` already carries via its own parallel bot PRs (even `--no-merges --cherry-pick --right-only` still lists them, since parallel bumps have different patch-ids). It cannot cheaply distinguish "develop is missing a main-only fix" from that expected topology noise. ## What changed Use a **content** diff that reflects final tree state, read directionally: - `git diff origin/main origin/develop` - hunks it would *remove* are content on `main` that `develop` lacks (real staleness); hunks it *adds* are `develop`'s normal unpromoted work. This also resolves the original Copilot objection to a plain `git diff` (that non-empty != stale): the fix is to read the diff's *direction*, not its emptiness. Verified on #235: for a clean `develop`, this diff was exactly the doc files `develop` adds - no `main`-only content - which is the correct "not stale" reading. Issue-closing keywords omitted (targets `develop`); no issue to close. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two durable learnings from the CI/CD work: mirror main-only fixes to develop (and check git diff origin/develop origin/main before relying on develop), and put Closes #N in the promotion PR. No code changes.