Frame the staleness-diff -/+ lines more precisely#238
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refines the documentation in AGENTS.md about how to interpret git diff origin/main origin/develop when checking whether develop is stale relative to main, clarifying that -/+ pairs can simply reflect normal develop modifications and that “main-only removals” are a stronger staleness indicator.
Changes:
- Rephrases the “develop staleness” guidance to treat
-lines as main-side differences to inspect, not automatically “real staleness”. - Adds nuance that a
-/+pair in a hunk is usually justdevelop’s own modification, while an unpaired-is a stronger staleness signal.
ptr727
force-pushed
the
docs/staleness-check-precision
branch
from
2a66361 to
4462e00
Compare
A `-`/`+` pair in one hunk is normally develop modifying that code (normal unpromoted work), not staleness, so "- lines = real staleness" overstated it. Reframe `-` lines as main-only differences to inspect, and call out that a `-` line with no develop-side replacement is the stronger staleness signal. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ptr727
force-pushed
the
docs/staleness-check-precision
branch
from
4462e00 to
1d94581
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #236, addressing a Copilot point raised on promotion PR #237: describing
-lines as "real staleness" and+lines as "just" unpromoted work overstates whatgit diff origin/main origin/developproves.Why
A hunk where
developmerely modified the same code shows both a-(main's old form) and a+(develop's new form) - that is normal unpromoted work, not staleness. Calling every-line "real staleness" is inaccurate.What changed
Reframe
-lines as main-only differences to inspect for staleness, and note that a-/+pair in one hunk is usually justdevelop's own modification; a-line with no correspondingdevelop-side replacement is the stronger staleness signal.Targets
develop; promotion PR #237 will carry it tomain.