Skip to content

Comments

Main#96

Merged
ptr727 merged 16 commits intomainfrom
develop
Feb 24, 2026
Merged

Main#96
ptr727 merged 16 commits intomainfrom
develop

Conversation

@ptr727
Copy link
Owner

@ptr727 ptr727 commented Feb 24, 2026

No description provided.

ptr727 and others added 15 commits January 29, 2026 21:35
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: ptr727 <2061579+ptr727@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…n and validation (#77)

- Updated XML documentation in LanguageTag.cs to clarify return values
and parsing behavior.
- Enhanced LanguageTagBuilder methods to specify that they set subtags
without validation.
- Improved normalization and validation methods in LanguageTagParser to
ensure null checks are handled properly.
- Added remarks in LogOptions to clarify the effects of setting logger
factory and logger after creation.
- Streamlined async file handling in Rfc5646Data to use 'using'
statements for better resource management.
- Updated tests to inherit from SingleInstanceFixture for consistent
test execution and resource management.
- Refined exception handling in Program.cs to ensure proper logging and
cleanup on errors.
- General code cleanup and consistency improvements across various
files.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: ptr727 <2061579+ptr727@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: ptr727 <2061579+ptr727@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: ptr727 <2061579+ptr727@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: ptr727 <2061579+ptr727@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: ptr727 <2061579+ptr727@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: ptr727 <2061579+ptr727@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Upgrade the AwesomeAssertions package to version 9.4.0 and adjust
workflows to improve code generation branch handling and pull request
triggers.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: ptr727 <2061579+ptr727@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings February 24, 2026 14:29
@ptr727 ptr727 enabled auto-merge (squash) February 24, 2026 14:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the codegen workflow branch naming and includes a minor dependency update. The changes simplify the automated codegen branch name from codegen-update to codegen and bump the AwesomeAssertions test package to version 9.4.0.

Changes:

  • Renamed codegen branch from codegen-update to codegen across all workflow files
  • Added codegen branch to test-pull-request.yml trigger branches
  • Updated AwesomeAssertions test package from 9.3.0 to 9.4.0

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
LanguageTagsTests/LanguageTagsTests.csproj Minor version bump for AwesomeAssertions test dependency (9.3.0 → 9.4.0)
.github/workflows/test-pull-request.yml Added codegen branch to pull request trigger list for test workflow
.github/workflows/run-codegen-pull-request-task.yml Changed codegen branch name from codegen-update to codegen and modified run command format
.github/workflows/merge-bot-pull-request.yml Updated merge condition to reference new codegen branch name
Comments suppressed due to low confidence (1)

.github/workflows/run-codegen-pull-request-task.yml:25

  • The run command format deviates from the established convention in this codebase. For single commands with multiple arguments, the convention is to use run: >- (folded block scalar) rather than run: | (literal block scalar) with backslash line continuation. This pattern is consistently used in other workflows like build-library-task.yml for similar dotnet commands with arguments. Using run: >- provides cleaner formatting without requiring backslash continuations.
        run: |
          dotnet run --project ./LanguageTagsCreate/LanguageTagsCreate.csproj -- \
            --codepath .

@ptr727 ptr727 merged commit eb1bfdc into main Feb 24, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant