Float dotnet/nbgv on @master instead of SHA-pinning#777
Merged
Conversation
The nbgv tag stream lags master substantially, so the v0.5.2 SHA pin only drew spurious Dependabot downgrade PRs. Consume it via @master (the documented no-SHA-pin exception) with the rationale inline, and record the rule in AGENTS.md. Converges with ESPHome/NxWitness which already float @master. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the reusable “get version” workflow to run Nerdbank.GitVersioning via dotnet/nbgv@master instead of a commit-SHA pin, and documents that choice in AGENTS.md to prevent future re-pinning.
Changes:
- Switch
dotnet/nbgvGitHub Action usage from a pinned commit SHA (v0.5.2) to the floating@masterref inget-version-task.yml. - Add an
AGENTS.mdrule statingdotnet/nbgvshould remain floated on@master, with rationale pointing back to the workflow comment.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| AGENTS.md | Adds guidance documenting the intended non-SHA-pinned consumption pattern for dotnet/nbgv. |
| .github/workflows/get-version-task.yml | Changes the dotnet/nbgv action ref from a pinned SHA to @master and adds inline rationale. |
The SHA-pin guarantee (D9.1) now notes dotnet/nbgv@master as the sole exception, matching the inline rationale and AGENTS.md, and converging with LanguageTags/Utilities which already document it. Keeps the workflow contract self-consistent after floating nbgv on @master. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Reword the inline comment and AGENTS note to the established cause (WORKFLOW.md D9.1 / 79-83): nbgv's tag stream lags master, so Dependabot tag-tracking would only propose downgrades to stale tags - not the imprecise "a pin draws downgrades" phrasing. Converges wording with the sibling repos. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
dotnet/nbgvtag stream lagsmastersubstantially, so the v0.5.2 SHA pin only drew spurious Dependabot downgrade PRs. This switches it to@master(the documented no-SHA-pin exception, with the rationale inline in the workflow) and records the rule inAGENTS.md.Converges with ESPHome-NonRoot / NxWitness, which already float
@master. Part of fleet-wide nbgv convergence.