Show default/total track counts in the default-flags detection warning#794
Merged
Conversation
The redundant Default flags warning reported only the Default-flagged count per track type, so it was not clear why a track was flagged. Report the count over the total track count per type (e.g. Video: 1/1, Audio: 1/1, Subtitle: 0/2) so the reason is visible: 1/1 is a lone track, 2/4 is multiple defaults. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the RepairDefaultFlags detection warning in ProcessFile to include both default-flagged and total track counts per track type, making it easier to understand why tracks are considered redundant-default candidates during processing.
Changes:
- Expand the
Redundant Default flags detectedwarning from per-type default counts todefault/totalcounts for Video/Audio/Subtitle. - Add a clarifying comment explaining how to interpret
1/1vs2/4scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
Redundant Default flags detectedwarning (added in #793) reported only the count ofDefault-flagged tracks per type (Video: 1, Audio: 1, Subtitle: 0), so it wasn't possible to tell why a track was flagged. Report the flagged count over the total track count per type instead:Redundant Default flags detected : Video: 1/1, Audio: 1/1, Subtitle: 0/2Now the reason is visible:
1/1— a lone track (a single track of a type needs noDefaultflag)2/4— multiple defaults (keep the preferred, clear the rest)Message-only change; full suite green (162).