SearchFilter: debounce input to fix typing flicker (#274)#321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #274.
Root cause
Every keystroke in the cards/relics/potions/etc. search box triggered:
setSearch(state update)router.replace(URL update)useEffectdeps includesearch→ API fetchThat cascade produced the visible flicker while typing.
Fix
Decoupled the
<input>value from the upstreamsearchprop. A localdraftstate advances on every keystroke (instant feedback), and the consumer'sonSearchChangeonly fires 200ms after typing stabilizes. Externalsearchprop changes (URL → state sync, clear-filter buttons) still flow back into the draft.Implemented inside
SearchFilter.tsxso all 9 consumers (cards, relics, potions, powers, events, encounters, enchantments, guides, browse) inherit the fix without touching their wiring.Uses a ref to hold the latest
onSearchChangecallback so the debounce timer isn't reset by parent re-renders that produce fresh inline arrow functions.