FFT filter changes with Numpy v2.0 #592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daurer
force-pushed
the
debug_fft_filter
branch
from
c20dfb6 to
832704c
Compare
…gle precision in Numpy > 2.0
daurer
force-pushed
the
debug_fft_filter
branch
from
939293e to
cf39bcd
Compare
kahntm
pushed a commit
that referenced
this pull request
Jan 8, 2025
* Include accelerate base tests by default * Change expected output in FFT filter tests to reflect support for single precision in Numpy > 2.0 * Adjust tolerance in pycuda fft filter tests
jcesardasilva
pushed a commit
that referenced
this pull request
Mar 21, 2025
* Include accelerate base tests by default * Change expected output in FFT filter tests to reflect support for single precision in Numpy > 2.0 * Adjust tolerance in pycuda fft filter tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test/accelerate_tests/base_tests/array_utils_test.py::ArrayUtilsTest::test_fft_filterseems to fail with numpy >=2.0Possibly related to the following line from the Numpy 2.0 release notes: