Conversation
daurer
approved these changes
Apr 27, 2025
Contributor
daurer
left a comment
daurer
left a comment
There was a problem hiding this comment.
@jcesardasilva sorry for the long delay. I have looked at your super resolution tutorial which looks good to me. I have downloaded your data and needed to make a few changes to get it work
- hardcoded the detector distance to
1.9364, the value from the h5 file was incorrect - set orientation to 4
- some minor typos
with this, I could reproduce your results
Happy to merge and upload as it is if you are happy with my changes...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first version of the superresolution tutorial. All seems to work for me, but I will be glad if someone else also wants to try it.