Notifications, scheduled tasks, global Assets library, and workspace enhancements

[kooksee]

Summary

• Scheduled Tasks & notifications: record-backed system type, task state, desktop notification fallback/navigation, reminder UX on pages/records
• Global Assets library: system-level asset_library database (like Scheduled Tasks); folders are filter tags; Settings → Assets with Gallery/Table/List/By folder; migration to meta-types space; collection-safe updates for on-demand node sync
• Archive: archive/unarchive nodes; hide archived items from sidebar, command palette, and meta-type views
• Backup: delete local backups from settings panel
• Docs & editor: Markdown page import/export round-trip, Mermaid in code blocks, meta-type property templates
• Desktop packaging: faster prePackage (symlink hoisted deps), better-sqlite3 upgrade, ad-hoc macOS signing for notifications

Test plan

• Desktop LOCAL_ONLY=true npm run package on Node 22; smoke-test app launch
• Settings → Scheduled Tasks: create/edit/run/delete task; verify notifications
• Settings → Assets: four views; Gallery thumbnails; no Assets in normal Space sidebar
• Create Folder → upload/import → asset appears in global Assets and folder filter view
• Archive a page → hidden from sidebar and meta-type views; restore works
• Backup panel: delete a backup file
• Command palette: "Open global Assets" quick action; Assets DB not in resource search
• npm run test in packages/client and packages/ui

Made with Cursor

[gemini-code-assist]

Code Review

This pull request introduces several major features, including a workspace-level global Asset Library, a robust Scheduled Tasks and Notifications system, Markdown import/export capabilities with frontmatter support, Mermaid diagram rendering in code blocks, and node archiving. It also adds backup deletion functionality and cleans up legacy tag-syncing code. The code review identified several critical issues: potential ReferenceErrors in forge.config.ts and field-create-popover.tsx due to missing variables or imports; performance and memory risks in main.ts and asset-library.ts from in-memory file reading and un-filtered node queries; a timezone bug in task date parsing; a data integrity risk during backup deletion; potential data loss when toggling scheduled tasks; a YAML serialization bug with reserved keywords; and a localization inconsistency in the backup panel.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

ReferenceError Risk

isLocalOnly is used here but it does not appear to be defined or imported in this file. This will cause a ReferenceError during the post-package step. Use process.env.LOCAL_ONLY === 'true' directly or define isLocalOnly at the top of the file.

Suggested change

	if (isLocalOnly && process.platform === 'darwin') {
	if (process.env.LOCAL_ONLY === 'true' && process.platform === 'darwin') {

[gemini-code-assist]

Performance & Memory Optimization

Reading the entire file into memory using fs.promises.readFile is highly inefficient and can cause out-of-memory (OOM) crashes for large files. Since the files are already on the local disk, you should copy them directly using fs.promises.copyFile instead of loading their contents into memory.

  for (const entry of entries) {
    try {
      const stat = await fs.promises.stat(entry.absolutePath);
      const mimeType = guessMimeTypeFromName(entry.name);
      const id = generateId(IdType.TempFile);
      const extension = app.path.extension(entry.name);
      const subtype = extractFileSubtype(mimeType);
      const filePath = app.path.tempFile(id + extension);

      await fs.promises.copyFile(entry.absolutePath, filePath);
      await app.database
        .insertInto('temp_files')
        .values({
          id,
          name: entry.name,
          size: stat.size,
          mime_type: mimeType,
          subtype,
          path: filePath,
          extension,
          created_at: new Date().toISOString(),
          opened_at: new Date().toISOString(),
        })
        .execute();

      const url = await app.fs.url(filePath);
      if (!url) {
        await app.fs.delete(filePath);
        await app.database
          .deleteFrom('temp_files')
          .where('id', '=', id)
          .execute();
        throw new Error('Failed to save temp file');
      }

      imported.push({
        id,
        name: entry.name,
        size: stat.size,
        mimeType,
        subtype,
        path: filePath,
        extension,
        url,
        relativePath: entry.relativePath,
      });
    } catch (error) {

[gemini-code-assist]

Timezone Bug

Parsing date-only strings (like 'YYYY-MM-DD') with new Date(raw) parses them as UTC midnight. Comparing this UTC date with a local-time-based endOfToday will cause reminders to trigger a day early or late depending on the user's local timezone offset. For example, a reminder for June 15th might trigger on the evening of June 14th in western timezones. Parse date-only strings in local time (e.g., by replacing hyphens with slashes: new Date(raw.replace(/-/g, '/'))) to avoid timezone shifts.

const parseFieldDate = (fieldValue: unknown): Date | null => {
  if (!fieldValue || typeof fieldValue !== 'object' || !('value' in fieldValue)) {
    return null;
  }

  const raw = (fieldValue as { value: unknown }).value;
  if (typeof raw !== 'string' || raw.length === 0) {
    return null;
  }

  const dateString = /^\d{4}-\d{2}-\d{2}$/.test(raw)
    ? raw.replace(/-/g, '/')
    : raw;

  const date = new Date(dateString);
  if (Number.isNaN(date.getTime())) {
    return null;
  }

  return date;
};

[gemini-code-assist]

Data Integrity Risk

If downloading or parsing any of the other manifests fails (e.g., due to a transient network error), the catch block silently ignores it. This means hashesStillNeeded will be incomplete, and you may permanently delete shared blobs that are still referenced by those other backups, corrupting them. You should abort the deletion or avoid deleting blobs if any other manifest cannot be successfully read.

        for (const key of otherManifestKeys) {
            const data = await this.provider.download(key);
            const otherManifest = JSON.parse(data.toString()) as BackupManifest;
            for (const file of otherManifest.files) {
                hashesStillNeeded.add(file.sha256);
            }
        }

[gemini-code-assist]

ReferenceError Risk

compareString is used here but it is not imported from @colanode/core in this file. This will cause a runtime ReferenceError. You can import compareString from @colanode/core, or simply use the native localeCompare method (e.g., b.index.localeCompare(a.index)) which is standard and requires no imports.

Suggested change

	const maxIndex = Object.values(options)
	.map((option) => option.index)
	.sort((a, b) => -compareString(a, b))[0];
	const index = generateFractionalIndex(maxIndex, null);
	const maxIndex = Object.values(options)
	.map((option) => option.index)
	.sort((a, b) => b.localeCompare(a))[0];
	const index = generateFractionalIndex(maxIndex ?? null, null);

[gemini-code-assist]

Correctness / Data Loss

In handleToggleEnabled, the scope and context properties of the task are omitted when calling the update mutation. This will cause the task's scope and context to be cleared or incorrectly re-derived, potentially breaking the reminder's target association. Please pass scope: task.scope and context: task.context to preserve them.

        task: {
          name: task.name,
          enabled,
          schedule: task.schedule,
          check: task.check,
          notify: task.notify,
          scope: task.scope,
          context: task.context,
        },

[gemini-code-assist]

i18n Consistency

The new backup deletion dialog and toast messages are written in Chinese, whereas the rest of the file and settings panel (like 'Restore', 'Delete backup', 'Scheduled Tasks') are in English. To maintain consistency, please translate these strings to English or use the project's i18n localization system if available.

Suggested change

	<AlertDialogTitle>确认删除备份</AlertDialogTitle>
	<AlertDialogDescription>
	将永久删除该备份，无法恢复。其他备份中仍被引用的文件块会保留以节省空间。
	</AlertDialogDescription>
	<AlertDialogTitle>Confirm Backup Deletion</AlertDialogTitle>
	<AlertDialogDescription>
	This will permanently delete the backup. It cannot be undone. Shared file blocks referenced by other backups will be kept to save space.
	</AlertDialogDescription>

[gemini-code-assist]

YAML Serialization Bug

In yamlScalar, string values that look like booleans ("true", `

const yamlScalar = (value: string | number | boolean): string => {
  if (typeof value === 'number' || typeof value === 'boolean') {
    return String(value);
  }

  const lower = value.toLowerCase();
  const isReservedKeyword =
    lower === 'true' ||
    lower === 'false' ||
    lower === 'yes' ||
    lower === 'no' ||
    lower === 'on' ||
    lower === 'off' ||
    lower === 'null';

  const isNumeric = /^-?\d+(\.\d+)?$/.test(value);

  if (
    value === '' ||
    isReservedKeyword ||
    isNumeric ||
    /[:#\n\r]/.test(value) ||
    value.startsWith(' ') ||
    value.endsWith(' ')
  ) {
    return JSON.stringify(value);
  }

  return value;
};

[gemini-code-assist]

Performance & Scalability

relocateAssetLibraryToMetaSpace fetches all database_view, record, and file nodes in the entire workspace and filters them in memory. For workspaces with a large number of files or records, this will be extremely slow and consume significant memory. Consider querying only the nodes associated with the target database by applying filters (e.g., filtering by parentId or databaseId) directly in the node.list query.