chore: decreased long poll timeout from 60s to 25s + race condition fix#16
Merged
SeverinAlexB merged 4 commits intomasterfrom Jan 21, 2026
Merged
chore: decreased long poll timeout from 60s to 25s + race condition fix#16SeverinAlexB merged 4 commits intomasterfrom
SeverinAlexB merged 4 commits intomasterfrom
Conversation
86667
approved these changes
Jan 21, 2026
SeverinAlexB
changed the title
86667
approved these changes
Jan 21, 2026
86667
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Timeout Decrease
So far, ln verification await timeout was 60s. This is higher than a lot of default request timeouts like on nginx for example. The request therefore has a high chance to timeout due to the proxy instead of the actual timeout in homegate.
This PR sets the homegate timeout to 25s which is lower than the default timeout of 30s that most proxies including nginx use. This avoids needing to manually configuring nginx.
This will not impact Franky in any way as Franky just keeps polling as long as it's needed.
Fix Race Condition
Also fixes two unlikely but possible race condition.