Skip to content

Conversation

@SimHacker
Copy link
Contributor

now supports multiple simulators, controller navigation tab has simulator menu, qr code urls set simulator to correspond with each simulator, user can switch controller's simulator with menu, menu updates when new simulators attach and leave.

…ator menu, qr code urls set simulator to correspond with each simulator, user can switch controller's simulator with menu, menu updates when new simulators attach and leave.
@mcarlson
Copy link
Contributor

Don can you change to merge to dev? We want to test there before pushing to main. Thank you!

Copy link
Contributor

@mcarlson mcarlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look fine, not super easy to review 27 files changed in a single commit tho. Please change to target dev (and ensure that works) and let's get this running - I'm excited to see it!

@SimHacker SimHacker changed the base branch from main to dev September 12, 2025 10:04
@SimHacker
Copy link
Contributor Author

Many of the changed files are because we are checking in build artifacts into the repo, so of course you can ignore all of those. There is no reason to review changes to machine generated files. And there are good reasons to follow established git development procedures and perform the builds during deployment and not check build artifacts in, of course. Which we should do, instead of checking artifacts in.

@SimHacker
Copy link
Contributor Author

Does digital ocean have a more sophisticated way of performing the build the way github actions can instead of literally copying build artifacts out of the repo, or should we use a github action to perform the build and deploy it on digital ocean the same way as github page builds should work, instead of putting bulky and distracting artifacts in the repo?

@SimHacker SimHacker merged commit e28806c into dev Sep 12, 2025
mcarlson added a commit that referenced this pull request Sep 14, 2025
…ator menu, qr code urls set simulator to correspond with each simulator, user can switch controller's simulator with menu, menu updates when new simulators attach and leave. (#53) (#55)

Co-authored-by: Don Hopkins <dhopkins@DonHopkins.com>
SimHacker added a commit that referenced this pull request Sep 16, 2025
* now supports multiple simulators, controller navigation tab has simulator menu, qr code urls set simulator to correspond with each simulator, user can switch controller's simulator with menu, menu updates when new simulators attach and leave. (#53) (#55)

Co-authored-by: Don Hopkins <dhopkins@DonHopkins.com>

* committing and pushing to main to work around new github actions bug

* added build trigger script

* tweaks

* tweaks

* tweaks

* Stop tracking ProjectVersion.txt via LFS; commit real text

* tweak

* tweak

* tweak

* tweak

* tweak

* tweak

* tweak

* tweak

* tweak

* tweak

* tweak

* tweak

* built

* tweak

* tweak

* tweak

* tweak

* tweak

* tweak

* tweak

* tweak

* tweak

---------

Co-authored-by: mcarlson <max@maxcarlson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants