Replaced BouncyCastle lib with System.Security.Cryptography.Algorithms #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
budgetpreneur
requested review from
crimsonred and
mohitpubnub
as code owners
crimsonred
reviewed
Nov 18, 2021
crimsonred
previously approved these changes
Nov 18, 2021
budgetpreneur
changed the title
budgetpreneur
changed the title
budgetpreneur
changed the title
crimsonred
previously approved these changes
Nov 26, 2021
crimsonred
suggested changes
Dec 13, 2021
| } | ||
| catch (Exception ex) | ||
| { | ||
| PNStatusCategory category = PNStatusCategoryHelper.GetPNStatusCategory(400, ex.ToString()); |
Contributor
There was a problem hiding this comment.
An Exception should not have the status code of 400
| } | ||
| } | ||
|
|
||
| internal async Task<PNResult<PNPublishResult>> Publish(string channel, object message, bool storeInHistory, int ttl, Dictionary<string, object> metaData, Dictionary<string, object> externalQueryParam) |
Contributor
There was a problem hiding this comment.
Most of the code is repeated in this method
Contributor
Author
There was a problem hiding this comment.
yeah..due to async/await and callback style outputs, some code was repeated due to threading issues. In the current PR only catch block section code was added to handle unknown exception which customer could not share. Remaining code nothing changed.
crimsonred
previously approved these changes
Dec 16, 2021
Contributor
Author
|
@client-engineering-bot release as v5.4.0.0 |
crimsonred
approved these changes
Dec 16, 2021
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Replaced BouncyCastle lib with System.Security.Cryptography.Algorithms
Replaced BouncyCastle lib with System.Security.Cryptography.Algorithms
fix: Added try/catch for publish operation to catch exceptions
Added try/catch for publish operation to catch exceptions