throw exception when uuid is not set #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
budgetpreneur
requested review from
crimsonred and
mohitpubnub
as code owners
crimsonred
previously approved these changes
Jan 4, 2022
|
@budgetpreneur I thought that we will if possible explicitly require it in constructor so code won't compile if it's not set |
Contributor
Author
C# SDK throws exception at Pubnub instance constructor initialization level. Not during compile level. So no UUID, nothing works, which meets our requirement. |
crimsonred
previously approved these changes
Jan 5, 2022
crimsonred
previously approved these changes
Jan 6, 2022
mohitpubnub
previously approved these changes
Jan 12, 2022
Contributor
Author
|
@client-engineering-bot release as v6.0.0.0 |
mohitpubnub
approved these changes
Jan 12, 2022
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: BREAKING CHANGE. UUID is mandatory to use SDK.
UUID is mandatory to use SDK.
BREAKING CHANGES: UUID is mandatory to use SDK.