Test coverage improvements #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for Set/Get/Remove/Manage channel members
…coverage-ai-improvements
jakub-grzesiowski
requested review from
Xavrax,
marcin-cebo and
mohitpubnub
as code owners
…ipShouldReturnSuccessCodeAndInfo
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
mohitpubnub
approved these changes
May 27, 2025
| } | ||
|
|
||
| [Test] | ||
| public static async Task ThenSetPresenceStateShouldWorkCorrectly() |
Contributor
There was a problem hiding this comment.
Just a thought! We may add some test to check, once we set the state. Presence Event Engine starts having state query parameter in it's heartbeat requests when maintainPresenceState = true.
Contributor
Author
|
@pubnub-release-bot release as v7.3.12.0 |
Contributor
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: CustomMessageType null string bug
Fixed an issue when upon receiving a message with published with a custom type the CustomMessageType would be null upon receiving
feat: improve integration tests
Added new integration tests to better cover all SDK endpoints