Emit PNDisconnectedUnexpectedlyCategory
#438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emit 'PNDisconnectedUnexpectedlyCategory' in cases when client receives bad request or unexpected / malformed service response. refactor(request): move deserialized error parse into abstract request Move error / malformed response handling into `AbstractRequest` to simplify actual endpoint classes.
parfeon
changed the title
PNDisconnectedUnexpectedlyCategoryPNDisconnectedUnexpectedlyCategory
parfeon
added
status: done
mohitpubnub
approved these changes
Feb 18, 2025
| parse(response) { | ||
| return __awaiter(this, void 0, void 0, function* () { | ||
| throw Error('Should be implemented by subclass.'); | ||
| return this.deserializeResponse(response); |
| */ | ||
| abort(): void { | ||
| if (this && this.cancellationController) this.cancellationController.abort(); | ||
| abort(reason?: string): void { |
|
@pubnub-release-bot release |
pubnub-release-bot
requested review from
kazydek and
techwritermat
as code owners
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(subscribe): emit
PNDisconnectedUnexpectedlyCategoryEmit 'PNDisconnectedUnexpectedlyCategory' in cases when client receives bad request or unexpected / malformed service response.
refactor(request): move deserialized error parse into abstract request
Move error / malformed response handling into
AbstractRequestto simplify actual endpoint classes.