Subscription set will subscribe added entities and SharedWorker will make proper subscribe throttling #443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`SubscriptionSet` will subscribe / unsubscribe added / removed `Subscription` or `SubscriptionSet` objects if the set itself already subscribed. fix(shared-worker): fix subscribe throttle Fix issue because of which throttle didn't consider difference in client settings (throttled only by user ID and subscribe key, which is not enough). fix(smart-heartbeat): fix smart heartbeat usage With the fix, smart heartbeat as feature has been added to the SDK, and it is disabled by default.
parfeon
added
status: done
|
@pubnub-release-bot release |
pubnub-release-bot
requested review from
kazydek and
techwritermat
as code owners
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(subscription-set): subscription set will subscribe added entities
SubscriptionSetwill subscribe / unsubscribe added / removedSubscriptionorSubscriptionSetobjects if the set itself already subscribed.BREAKING CHANGES: No need to call
subscribe()/unsubscribe()forSubscriptionandSubscriptionSetadded into / removed from already subscribedSubscriptionSetfix(shared-worker): fix subscribe throttle
Fix issue because of which throttle didn't consider difference in client settings (throttled only by user ID and subscribe key, which is not enough).
fix(smart-heartbeat): fix smart heartbeat usage
With the fix, smart heartbeat as feature has been added to the SDK, and it is disabled by default.