Fixed upload/download encrypted file API #383
Conversation
When file is encrypted "application/octet-stream" data format is enforced regardless of original file type (image/jpeg, video/mp4, text/plain) or server's suggested Content-Type from generateUploadUrl
marcin-cebo
requested review from
jakub-grzesiowski,
jguz-pubnub,
kleewho and
parfeon
as code owners
|
|
||
| @Test | ||
| fun uploadListDownloadDeleteWithCipherUseFileWithLegacyCryptoModule(){ | ||
| fun uploadListDownloadDeleteWithCipherUseFileWithLegacyCryptoModule() { |
There was a problem hiding this comment.
What does this test case cover? Have you considered other names for it?
uploadListDownloadDeleteWithCipherUseFileWithLegacyCryptoModule is quite long, and the same applies to uploadListDownloadDeleteWithCipherUseFileWithAesCbcCryptoModule below
EDIT: I see it uploads an encrypted File, then downloads a File from the remote server and compares their contents. If so, what do you think of the following, or something similar?
aesCbcEncryptedFileTransfer
legacyEncryptedFileTransfer
There was a problem hiding this comment.
These tests: upload, then list, then delete file using aesCbc/legacy cryptoModule.
I like proposed names. I will use them.
|
@pubnub-release-bot release kotlin as v12.0.1 |
|
🚀 Release successfully completed 🚀 |
3 participants
fix: Fixed upload/download encrypted file API.
Fixed upload/download encrypted file API. When file is encrypted application/octet-stream data format is enforced regardless of original file type (image/jpeg, video/mp4, text/plain) or server's suggested Content-Type from generateUploadUrl.
fix: Removed redundant buffering when parsing encrypted data.