Skip to content

Conversation

@parfeon
Copy link
Contributor

@parfeon parfeon commented May 30, 2023

feat(retry-policy): add request retry policy

Add RequestRetryPolicy for delay computation between failed requests to retry.

fix(reqwest-response): fix missing headers

Fix missing headers in RequestResponse struct when used with reqwest crate.

Add `RequestRetryPolicy` for delay computation between failed requests retry.

fix(reqwest-response): fix missing headers

Fix missing `headers` in `RequestResponse` struct when used with `reqwest` crate.
@parfeon parfeon requested a review from Xavrax as a code owner May 30, 2023 12:45
@parfeon parfeon self-assigned this May 30, 2023
Copy link
Contributor

@Xavrax Xavrax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I would prefer to use Duration instead of u32.

@Xavrax
Copy link
Contributor

Xavrax commented May 30, 2023

But it would be nice to use e.g. https://docs.rs/time/latest/time/struct.Duration.html

@parfeon parfeon merged commit 177252d into phoenix May 30, 2023
@parfeon parfeon deleted the clen-12894/add-reconnection-retry-policy branch May 30, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants