Subscribe EE works with presence EE #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On subscription changes and restore subscribe event engine should inform presence event engine about such events so `user_id` presence will be properly updated. feat(subscribe): add missing `disconnect` and `reconnect` methods Add method which let users temporarily stop real-time updates processing and restore when it will be needed.
parfeon
added
priority: medium
parfeon
requested review from
kleewho,
marcin-cebo and
mohitpubnub
as code owners
Xavrax
added
priority: high
`unsubscribe_all` will go through `Subscription` instances and force waker to schedule their polling and return `Poll::Ready(None)` from `poll_next`. test(contract): temporarily disable the presence event engine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(event_engine): subscribe EE works with presence EE
On subscription changes and restore, the subscribe event engine should inform the presence event engine about such events so
user_idpresence will be properly updated.feat(subscribe): add missing
disconnectandreconnectmethodsAdd method which lets users temporarily stop real-time updates processing and restore when it will be needed.