Add getting started guides to PubNub.xcworkspace #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jguz-pubnub
requested review from
kazydek,
marcin-cebo,
parfeon and
techwritermat
as code owners
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
jguz-pubnub
changed the title
marcin-cebo
approved these changes
Jun 18, 2025
| { | ||
| "idiom" : "universal", | ||
| "platform" : "ios", | ||
| "size" : "1024x1024" |
There was a problem hiding this comment.
Shouldn't filename be added here like:
{
"idiom" : "universal",
"platform" : "ios",
"size" : "1024x1024",
"filename" : "your_app_icon.png" // <--- Missing filename
},
Contributor
Author
There was a problem hiding this comment.
It is required if you would like to submit your app to the AppStore.
We don't need an app icon for a Getting Started guide showing how to integrate an SDK
| "appearances" : [ | ||
| { | ||
| "appearance" : "luminosity", | ||
| "value" : "tinted" |
There was a problem hiding this comment.
Is tinted valid value for appearance?
Contributor
Author
There was a problem hiding this comment.
Yes, this file is automatically generated if you create a new Xcode project from scratch
jguz-pubnub
force-pushed
the
feat/getting-started-guides
branch
from
a350363 to
66cb595
Compare
jguz-pubnub
force-pushed
the
feat/getting-started-guides
branch
2 times, most recently
from
590c843 to
5b2b3e6
Compare
techwritermat
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: add Getting Started guides to PubNub.xcworkspace as example iOS applications
chore: update
Fastfileand standardize its environment files