Add acceptance tests #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix `artifacts` field content and align with specs requirement. docs(.pubnub.yml): fix missing feature entries Update features matrix with information about auth token parse and set features.
Update list of codeowners of `.pubnub.yml` file.
Add contract based acceptance tests. fix(api-client): fix hostname encoding Fix issue because of which it is impossible to set hostaname with specific port number.
Remove feature files from repository and let GitHub Actions handle them.
Make it possible for CI/CD to pass when beta contracts fail.
parfeon
added
priority: medium
parfeon
requested review from
CraigLn,
crimsonred and
techwritermat
as code owners
Use newly exposed environment variable in attempt to solve show build settings timeout.
Add dependencies pulled out by CocoaPods to cache for build speedup.
Add gems installed by bundler to cache for build speedup.
Use bundler to install and run fastlane, to make GitHub Action cache useful.
Fix path which is used to store acceptance tests result for artifacts upload.
CraigLn
approved these changes
Nov 3, 2021
crimsonred
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(api-client): fix hostname encoding
Fix issue because of which it is impossible to set hostaname with specific port number.
test(contract): add acceptance tests
Add contract based acceptance tests.