Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #48 +/- ##
==========================================
+ Coverage 88.69% 88.82% +0.13%
==========================================
Files 19 19
Lines 2734 2757 +23
==========================================
+ Hits 2425 2449 +24
+ Misses 309 308 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using ESPHome serial proxy port instance IDs to refer to ports, we should use the user-friendly
name. I've taken this opportunity to clean up the URI format.Before:
After:
Python code that knows it's directly communicating with an ESPHome device should instead pass these as kwargs to either
Serial.from_url(sync) oropen_serial_connection(async) to avoid dealing with URI encoding.The old format is still supported for convenience. In addition, we now support passing an external aioesphomeapi instance, which allows for creating and tearing down serial connections without opening a new API connection to a device.