Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #49 +/- ##
==========================================
+ Coverage 88.82% 88.92% +0.10%
==========================================
Files 19 19
Lines 2757 2782 +25
==========================================
+ Hits 2449 2474 +25
Misses 308 308 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #47.
aioesphomeapi has its own timeout error type and in general raises predictable errors. To ensure that we do not leak unrelated errors by accident (i.e
APIConnectionError), this PR introduces a decorator and wraps all functions interacting with aioesphome in it.I've expanded the host daemon program used for testing to allow enabling/disable Noise encryption at runtime which lets us test the encryption combinations more explicitly.