Adds tests and makes sure errors are not swallowed#2
Merged
dominictarr merged 1 commit intopull-stream:masterfrom Nov 1, 2018
Merged
Adds tests and makes sure errors are not swallowed#2dominictarr merged 1 commit intopull-stream:masterfrom
dominictarr merged 1 commit intopull-stream:masterfrom
Conversation
Member
|
🙏 please can we have merge & release? |
Member
|
thanks! great work. merged into 1.0.1 |
Member
|
make that 1.0.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a pull-stream source/through in the pipeline before a
pull-sortstep results in an error, the error is swallowed and an empty array is passed on to the next step.This PR:
pull-streamas described in thepull-streamreadme under minimal bundle.