Skip to content

Adds tests and makes sure errors are not swallowed#2

Merged
dominictarr merged 1 commit intopull-stream:masterfrom
achingbrain:master
Nov 1, 2018
Merged

Adds tests and makes sure errors are not swallowed#2
dominictarr merged 1 commit intopull-stream:masterfrom
achingbrain:master

Conversation

@achingbrain
Copy link
Copy Markdown
Contributor

If a pull-stream source/through in the pipeline before a pull-sort step results in an error, the error is swallowed and an empty array is passed on to the next step.

This PR:

  1. Ensures the error is passed on instead
  2. Adds some tests for that & the happy path
  3. Adds missing dependencies
  4. Ensures this module won't pull in all of pull-stream as described in the pull-stream readme under minimal bundle.

@alanshaw
Copy link
Copy Markdown
Member

🙏 please can we have merge & release?

@dominictarr dominictarr merged commit 68fccdd into pull-stream:master Nov 1, 2018
@dominictarr
Copy link
Copy Markdown
Member

thanks! great work. merged into 1.0.1

@dominictarr
Copy link
Copy Markdown
Member

make that 1.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants