Skip to content

Hopefully fixing github actions run#2

Merged
tabathad merged 3 commits intomasterfrom
fix-ci
Sep 3, 2025
Merged

Hopefully fixing github actions run#2
tabathad merged 3 commits intomasterfrom
fix-ci

Conversation

@suprjinx
Copy link
Contributor

@suprjinx suprjinx commented Sep 2, 2025

No description provided.

Signed-off-by: Geoff Wilson <geoff@gr-oss.io>
Signed-off-by: Geoff Wilson <geoff@gr-oss.io>
Signed-off-by: Geoff Wilson <geoff@gr-oss.io>
@suprjinx suprjinx requested a review from Copilot September 2, 2025 19:47
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR simplifies the CI workflow configuration by removing development-specific dependencies and unused workflow components. The changes appear to be aimed at fixing GitHub Actions run issues as indicated by the title.

Key changes:

  • Updates branch references from "main" to "master" for workflow triggers
  • Removes references to .devcontainer/requirements-override.txt dependency file
  • Eliminates the test-make job and associated test-summary job that depended on it

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/ci.yml Updates branch triggers, removes devcontainer dependencies, eliminates test-make workflow, and upgrades upload-artifact action
.devcontainer/devcontainer.json Removes requirements-override.txt installation from post-create command
Comments suppressed due to low confidence (1)

.github/workflows/ci.yml:1

  • The test-summary job references 'test-make' in its needs array, but the test-make job has been removed. This will cause the workflow to fail since it's trying to depend on a non-existent job.
name: CI

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@tabathad tabathad self-requested a review September 3, 2025 14:44
@tabathad tabathad merged commit 53b943b into master Sep 3, 2025
2 checks passed
@suprjinx suprjinx deleted the fix-ci branch September 4, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants