Conversation
|
WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue. |
gerrod3
force-pushed
the
github_issues
branch
2 times, most recently
from
78f5d7e to
c2e8c48
Compare
| {% if issue_tracker=='redmine' %} | ||
| issue_format = "`#{issue} <https://pulp.plan.io/issues/{issue}>`_" | ||
| {% else %} | ||
| issue_format = "`#{issue} <https://github.com/pulp/{{ plugin_name }}/issues/{issue}>`_" |
There was a problem hiding this comment.
Should we add support for different orgs here?
There was a problem hiding this comment.
I think this might require a separate PR. There are other templates where we have Github links with the Pulp org.
| Visit [our tracker](https://pulp.plan.io/projects/{{ redmine_project }}/issues/new) to file a {{ plugin_dash }} issue. | ||
| {% else %} | ||
| File through this project's GitHub issues and appropriate labels. | ||
| {% endif %} |
There was a problem hiding this comment.
Maybe we should allow not to specify any issue tracker too.
| {% if issue_tracker=='redmine' %} | ||
| issue_format = "`#{issue} <https://pulp.plan.io/issues/{issue}>`_" | ||
| {% else %} | ||
| issue_format = "`#{issue} <https://github.com/pulp/{{ plugin_name }}/issues/{issue}>`_" |
| print(f"\nDon't forget to migrate current issues from https://pulp.plan.io/projects/{redmine}" | ||
| f" and remove the repo from the project settings") |
There was a problem hiding this comment.
do we have some script for it?
If so, can we link it here?
There was a problem hiding this comment.
This is the script I found https://github.com/IQSS/redmine2github that I was talking about in our previous meeting. I haven't tested it, but would you still like me to add a link to it?
There was a problem hiding this comment.
sorry, I forgot to reply, if it is not tested, it is better not to adding it
gerrod3
force-pushed
the
github_issues
branch
3 times, most recently
from
e74783d to
72bdc90
Compare
mdellweg
left a comment
mdellweg
left a comment
There was a problem hiding this comment.
So should we merge this before or after it has been tested with pulp_ansible?
| config['update_redmine'] = False | ||
| write_template_section(config, "generate_config", plugin_root_dir, verbose=verbose) | ||
| write_template_section(config, "github", plugin_root_dir, verbose=verbose) | ||
| print("\nUpdating pyproject.toml to point to GitHub issues") |
There was a problem hiding this comment.
Why should a print statement start with a newline?
There was a problem hiding this comment.
It was done earlier in the script. I changed it to after.
|
|
||
| def migrate_github_issues(config, plugin_root_dir, verbose=False): | ||
| """Moves the plugin's issue checker CI/CD off of Redmine and onto GitHub""" | ||
| config['issue_tracker'] = 'github' |
There was a problem hiding this comment.
| config['issue_tracker'] = 'github' | |
| print("Updating template_config.yml and and templating ci section") | |
| config['issue_tracker'] = 'github' |
gerrod3
force-pushed
the
github_issues
branch
2 times, most recently
from
832c681 to
d075e96
Compare
I already testing this with pulp_python pulp/pulp_python#355 |
[noissue]
4 participants
[noissue]
Adding new config option, plus a --migrate-github-issues command to help plugins move off of Redmine in the future. This PR follows the instructions @daviddavis came up with here: https://hackmd.io/y3AnY_bCQCODemWQk2bfoQ?both. I'm going to test this out soon on Pulp Python after its next release.