Conversation
ggainey
reviewed
Apr 23, 2026
| from importlib.resources import files | ||
|
|
||
|
|
||
| # Need to call lru_cache() before using it as a decorator for python 3.7 compatibility |
Contributor
There was a problem hiding this comment.
(unrelated to the PR - we can prob drop this comment now that we require py3.10+)
Member
Author
There was a problem hiding this comment.
Specifically now that we don't use lru_cache at all anymore.
ggainey
previously approved these changes
Apr 23, 2026
Contributor
ggainey
left a comment
ggainey
left a comment
There was a problem hiding this comment.
Looks like it even caught a few subtle L10N bugs (i.e. changing _("".format()) to _("").format()
ggainey
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.