Skip to content

Log the task state after calling set_running()#812

Merged
dkliban merged 1 commit into
pulp:mainfrom
dkliban:more-logging-state
Dec 20, 2025
Merged

Log the task state after calling set_running()#812
dkliban merged 1 commit into
pulp:mainfrom
dkliban:more-logging-state

Conversation

@dkliban
Copy link
Copy Markdown
Member

@dkliban dkliban commented Dec 20, 2025

Summary by Sourcery

Maintain patch file placeholder for NewPulpcoreWorker integration without introducing functional changes

@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented Dec 20, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the Pulp core worker patch to log the task state immediately after set_running() is called, improving observability of task lifecycle transitions during worker execution.

File-Level Changes

Change Details Files
Add logging of task state immediately after invoking set_running() in the patched Pulp core worker code.
  • Invoke logging right after set_running() to record the updated task state
  • Ensure the log message includes enough context to identify the task and its new state
  • Wire the new logging into the existing worker lifecycle so it only fires on state transitions to running
images/assets/patches/0033-Adds-use-of-NewPulpcoreWorker-from-pulp_service.patch

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@dkliban dkliban merged commit 93dadf9 into pulp:main Dec 20, 2025
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant