Skip to content

Fix migration 42 when installing with pulpcore>=3.108#2516

Merged
gerrod3 merged 1 commit intopulp:mainfrom
gerrod3:gpg-migration-core-108
Apr 15, 2026
Merged

Fix migration 42 when installing with pulpcore>=3.108#2516
gerrod3 merged 1 commit intopulp:mainfrom
gerrod3:gpg-migration-core-108

Conversation

@gerrod3
Copy link
Copy Markdown
Contributor

@gerrod3 gerrod3 commented Apr 14, 2026

Can't rely on the gnupg dependency being there anymore.

📜 Checklist

  • Commits are cleanly separated with meaningful messages (simple features and bug fixes should be squashed to one commit)
  • A changelog entry or entries has been added for any significant changes
  • Follows the Pulp policy on AI Usage
  • (For new features) - User documentation and test coverage has been added

See: Pull Request Walkthrough

Comment on lines +11 to +12
except ImportError:
print("gnupg is not installed, skipping migration")
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we need to provide a little bit more information somewhere.
If I read the rest of the file correctly, it is built to be resiliant but also talks about the repositories failed to migrate.
Otoh it's a rather old migration that just ever so slightly missed the (first) last squashing.
Can we purge migrations at this point and squash again?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can get away with it, because every installation of a supported branch must have run this migration already.
Also:
#2517

Comment on lines +11 to +12
except ImportError:
print("gnupg is not installed, skipping migration")
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can get away with it, because every installation of a supported branch must have run this migration already.
Also:
#2517

@gerrod3 gerrod3 merged commit 6a57fd0 into pulp:main Apr 15, 2026
13 of 14 checks passed
@patchback
Copy link
Copy Markdown

patchback bot commented Apr 15, 2026

Backport to 0.29: 💚 backport PR created

✅ Backport PR branch: patchback/backports/0.29/6a57fd0c5c688c2690274cc44926e47b72d92f9e/pr-2516

Backported as #2518

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants